Re: [Xen-devel] [PATCH v2 5/9] xen: arm: implement arch/platform SMP and CPU initialisation framework

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-09-26 at 15:06 +0100, Julien Grall wrote:
> On 09/26/2013 11:49 AM, Ian Campbell wrote:
> > +
> > +static int vexpress_smp_init(void)
> > +{
> > +    void __iomem *sysflags;
> > +
> > +    sysflags = ioremap_nocache(V2M_SYS_MMIO_BASE, PAGE_SIZE);
> > +    if ( !sysflags )
> > +    {
> > +        dprintk(XENLOG_ERR, "Unable to map vexpress MMIO\n");
> > +        return -EFAULT;
> > +    }
> > +
> > +    printk("Set SYS_FLAGS to %"PRIpaddr" (%p)\n",
> > +           __pa(init_secondary), init_secondary);
> > +    iowritel(sysflags + V2M_SYS_FLAGSCLR, ~0);
> > +    iowritel(sysflags + V2M_SYS_FLAGSSET,
> > +             __pa(init_secondary));
> 
> You need to replace iowritel by writel.

Yeah, need to rebase from the looks of things.

> Otherwise:
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel