Re: [Xen-devel] [PATCH v6 4/5] xen: introduce XENMEM_exchange_and_pin and XENMEM_unpin

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 30 Sep 2013, Jan Beulich wrote:
> >>> On 27.09.13 at 18:15, Stefano Stabellini 
> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > Changes in v6:
> > - do not change error paths;
> > - crash the guest on pinning failure;
> 
> Isn't that a little harsh?

I agree that this is harsh, but it's quite difficult to undo the
page exchange that was previously done up to the point of failure. And a
pinning error can only be caused by a misbehaviour of the guest.
Overall this is a simple solution to a difficult problem.

I'll make the changes according to all the comments, thanks.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel