Re: [Xen-devel] [PATCH] Allow building of XEN from source on a system without internet access.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.10.13 at 15:17, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
> Do the same with XEN_EXTFILES_URL, QEMU_REMOTE, IPXE_GIT_URL, and 
> IPXE_TARBALL_URL as QEMU_UPSTREAM_URL, SEABIOS_UPSTREAM_URL, etc.
> 
> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
> ---
>  Config.mk                         |    6 +++---
>  tools/firmware/etherboot/Makefile |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index a26c7c0..8bbab8a 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -212,15 +212,15 @@ EMBEDDED_EXTRA_CFLAGS += -fno-exceptions
>  XSM_ENABLE ?= n
>  FLASK_ENABLE ?= $(XSM_ENABLE)
>  
> -XEN_EXTFILES_URL=http://xenbits.xen.org/xen-extfiles 
> +XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles 

Given the change here and further down - what is it that doesn't
work when you run "make XEN_EXTFILES_URL=..."? I understand
that you may want to pass these settings through the environment,
but if the command line approach works the patch title is wrong.

Jan

>  # All the files at that location were downloaded from elsewhere on
>  # the internet.  The original download URL is preserved as a comment
>  # near the place in the Xen Makefiles where the file is used.
>  
>  ifeq ($(GIT_HTTP),y)
> -QEMU_REMOTE=http://xenbits.xen.org/git-http/qemu-xen-unstable.git 
> +QEMU_REMOTE ?= http://xenbits.xen.org/git-http/qemu-xen-unstable.git 
>  else
> -QEMU_REMOTE=git://xenbits.xen.org/qemu-xen-unstable.git
> +QEMU_REMOTE ?= git://xenbits.xen.org/qemu-xen-unstable.git
>  endif
>  
>  ifeq ($(GIT_HTTP),y)
> diff --git a/tools/firmware/etherboot/Makefile 
> b/tools/firmware/etherboot/Makefile
> index 15561fc..a0578d2 100644
> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -5,14 +5,14 @@ include $(XEN_ROOT)/tools/Rules.mk
>  include Config
>  
>  ifeq ($(GIT_HTTP),y)
> -IPXE_GIT_URL := http://git.ipxe.org/ipxe.git 
> +IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git 
>  else
> -IPXE_GIT_URL := git://git.ipxe.org/ipxe.git
> +IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
>  endif
>  
>  IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e
>  
> -IPXE_TARBALL_URL := $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
> +IPXE_TARBALL_URL ?= $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
>  
>  D=ipxe
>  T=ipxe.tar.gz
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel