Re: [Xen-devel] [PATCH v2] remove unnecessary null pointer checks before frees

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, Oct 3, 2013 at 2:43 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Sun, 2013-09-29 at 16:26 +1300, Matthew Daley wrote:
>> Oops, spatch removed an #if 0'd hunk from gtraceview.c. Here's a fixed 
>> version:
>>
>> -- 8< --
>>
>> Patch generated by the following semantic patch
>> (http://coccinelle.lip6.fr/):
>>
>> @@
>> expression *P;
>> @@
>>
>> - if(P) free(P);
>> + free(P);
>>
>> ...and then by filtering through the following command:
>>
>> filterdiff -p1 -x 'stubdom/*' -x 'tools/firmware/*' -x 'tools/qemu-*'
>>
>> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
>> ---
> [...]
>>  tools/blktap/drivers/blktapctrl.c    |    6 ++----
>>  tools/blktap/drivers/tapaio.c        |   18 ++++++----------
>>  tools/blktap/drivers/tapdisk.c       |    9 +++-----
>>  tools/blktap/lib/xenbus.c            |   21 +++++++------------
>>  tools/blktap/lib/xs_api.c            |    3 +--
>>  tools/blktap2/control/tap-ctl-list.c |    6 ++----
>>  tools/blktap2/drivers/block-log.c    |    3 +--
>
> I'm slightly inclined to not touch these unmaintained bits, especially
> blktap1 from a "if it aint' broke" type mentality and a reluctance to
> touch it even for such an obviously correct change.
>
> What do others think?

That certainly sounds reasonable.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel