Re: [Xen-devel] [Patch] hvm/vidirian: Avoid printing page_to_mfn(NULL) on error paths.

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 08/10/2013 21:17, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx> wrote:

> While working in the viridian code, I noticed that 4cb6c4f4941
> 
> "x86/hvm: Use get_page_from_gfn() instead of get_gfn()/put_gfn."
> 
> introduced two error paths where page_to_mfn(NULL) would be formatted and
> presented as a bad MFN.  This provides junk in the warning rather than
> something useful.
> 
> These two codepaths are fixed up to match their counterpart in
> wrmsr_hypervisor_regs()
> 
> While auditing the other changes from 4cb6c4f4941, I noticed a small
> optimisation which could be made by changing the order of the validity checks
> to remove 6 NULL pointer checks.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Tim Deegan <tim@xxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel