Re: [Xen-devel] [PATCH 07/15] xl: test script for the cpumap parser (for vCPU pinning)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-10-03 at 19:46 +0200, Dario Faggioli wrote:
> This commit introduces "check-xl-vcpupin-parse" for helping
> verifying and debugging the (v)CPU bitmap parsing code in xl.
> 
> The script runs "xl -N vcpu-pin 0 all <some strings>"
> repeatedly, with various input strings, and checks that the
> output is as expected.
> 
> This is what the script can do:
> 
> # ./check-xl-vcpupin-parse -h
>  usage: ./check-xl-vcpupin-parse [options]
> 
>  Tests various vcpu-pinning strings. If run without arguments acts
>  as follows:
>   - generates some test data and saves them in
>     check-xl-vcpupin-parse.data;
>   - tests all the generated configurations (reading them back from
>     check-xl-vcpupin-parse.data).
> 
>  An example of a test vector file is provided in
>  check-xl-vcpupin-parse.data-example.
> 
>  Options:
>   -h         prints this message
>   -r seed    uses seed for initializing the rundom number generator
>              (default: the script PID)
>   -s string  tries using string as a vcpu pinning configuration and
>              reports whether that succeeds or not
>   -o ofile   save the test data in ofile
>              (default: check-xl-vcpupin-parse.data)
>   -i ifile   read test data from ifile
> 
> An example test data file (generated on a 2 NUMA nodes, 16 CPUs
> host) is being provided in check-xl-vcpupin-parse.data-example.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(I haven't actually reviewed this in much detail, any test case is
better than none IMHO)
[...]

> +#
> +# Testing a wring configuration

There's a certain irony in spelling wrong incorrectly I think ;-)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel