Re: [Xen-devel] [PATCH] xl: skip zero-size config data in list_domains_details

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Oct 22, 2013 at 10:27:39AM +0100, Wei Liu wrote:
> On Tue, Oct 22, 2013 at 10:17:00AM +0100, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH] xl: skip zero-size config data in 
> > list_domains_details"):
> > > libxl_userdata_retrieve returns 0 when there's no stored config file for
> > > a domain, so we cannot rely on that to continue processing.
> > 
> > How could a zero-sized config userdata ever arise ?
> > 
> 
> When Xen cannot clean up a domain after its death, it remains visible in
> Xen in -p-sd state. Xl list -l will still try to retrieve the config
> file, which has been deleted at that time.
> 
> > I haven't tried it but presumably, at the moment, continuing causes
> > some kind of other errors later (complaints about missing config
> > entries perhaps) ?
> > 
> 
> Yes, this leads to 'Domain name must be specified' because the config
> data is NULL, aborting 'xl list -l'.
> 

Just to make clear, 'Domain name must be specified' doesn't cause the
abortion of 'xl list -l', it's the call to generate json output that
aborts 'xl list -l'.

Wei.

> Wei.
> 
> > Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel