Re: [Xen-devel] [PATCH v2] Nested VMX: CR emulation fix up

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Yang Zhang <yang.z.zhang@xxxxxxxxx> 10/23/13 9:20 AM >>>
>From: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>
>This patch fixs two issues:
>1. The CR_READ_SHADOW should only cover the value that L2 wirtes to
>CR when L2 is running. But currently, L0 wirtes wrong value to
>it during virtual vmentry and L2's CR access emualtion.
>
>2. L2 changed cr[0/4] in a way that did not change any of L1's shadowed
>bits, but did change L0 shadowed bits. In this case, the effective cr[0/4]
>value that L1 would like to write into the hardware is consist of
>the L2-owned bits from the new value combined with the L1-owned bits
>from L1's guest cr[0/4].
>
>Signed-off-by: Yang Zhang <yang.z.zhang@xxxxxxxxx>
>Acked-by: "Dong, Eddie" <eddie.dong@xxxxxxxxx>

I don't think this can be counted as ack - neither do I recall having seen this
ack on the list, nor did you Cc Eddie (I specifically did not alter the Cc list
here), i.e. he would also have no way to communicate his objection to this.
Please be transparent here (and I think I told you to Cc maintainers on your
patches enough times by now).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel