Re: [Xen-devel] [PATCH 29/29] xentrace: undeadify invalid option argument handling

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 30/10/13 07:52, Matthew Daley wrote:
> Apparently it's always been like this.
>
> Coverity-ID: 1056153
> Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
Weird!

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

> ---
>   tools/xentrace/xentrace.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/xentrace/xentrace.c b/tools/xentrace/xentrace.c
> index 504763d..8a38e32 100644
> --- a/tools/xentrace/xentrace.c
> +++ b/tools/xentrace/xentrace.c
> @@ -858,10 +858,11 @@ long sargtol(const char *restrict arg, int base)
>   
>   
>       return val;
> +
>   invalid:
> -    return 0;
>       fprintf(stderr, "Invalid option argument: %s\n\n", arg);
>       usage();
> +    return 0; /* not actually reached */
>   }
>   
>   /* convert the argument string pointed to by arg to a long int representation */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel