[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Fixes for various minor Coverity issues, volume 3

On Fri, Nov 1, 2013 at 11:10 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2013-10-31 at 12:28 +0000, Andrew Cooper wrote:
>> On 30/10/13 07:51, Matthew Daley wrote:
>> > This also includes a couple of non-Coverity-spotted issues which were found
>> > while working on said Coverity-spotted issues.
>> >
>> > Tested by make installing the entire tree, creating a few PV domains w/ xl,
>> > using vchan-node2 (libvchan) and xenctx.
>> >
>> Having now had an opportunity to look at all of the patches, everything
>> appears to be in order
>> Therefore, all (including v2's where appropriate)
>> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Thanks. I've applied the bulk of this, picking up v2 (hopefully) as
> appropriate:
>         96be5ea xentrace: undeadify invalid option argument handling
>         7343db9 xentrace: don't try to close null libxc handle in 
> disable_tbufs
>         1924ed3 xenctx: correct error check when opening libxc
>         33d3716 xenctx: only alloc symbol if we are inserting it into the 
> symbol table
>         f2f06a2 libvchan: handle libxc evtchn failures properly in init 
> functions
>         93700cb docs: make `xl vm-list` example use verbatim formatting
>         9d801e2 xl: correct references to long-removed function in error 
> messages
>         50b9bdf xl: remove needless infinite-loop construct in create_domain
>         77d8f86 xl: check for restore file open failure in create_domain
>         235f16a xl: libxl_list_vm returns a pointer, not a handle
>         2ffc14e libxl: only close fds which successfully opened in 
> libxl__spawn_local_dm
>         1edd6d8 libxl: don't leak memory in libxl__poller_get failure case
>         4b62556 libxl: correct file open success check in 
> libxl__device_pci_reset
>         5bc3a84 libxl: check for transaction abortion failure in 
> libxl_set_memory_target
>         d6dea2f libxc: remove null pointer checks in xc_pm_get_{c, p}xstat
>         492da27 libxc: initalize stdio loggers' progress_last_percent values 
> to 0
>         e1fde2a libxc: check for xc_domain_get_guest_width failure in 
> xc_domain_resume_any
>         6b02836 libxc: remove pointless null pointer check in 
> xc_interface_open_common
>         fcaacad libxc: tidy up loop construct in write_compressed
>         f46fa80 libxc: don't ignore fd read failures when restoring a domain
>         9fae04f libxc: fix memory leak in move_l3_below_4G error handling
>         e9fa4c8 libxc: fix retrieval of and remove pointless check on gzip 
> size
> I think I replied to everything which I didn't apply (or else observed
> that someone else had replied) but I'm afraid I didn't keep detailed
> notes, hopefully "git rebase" will make it obvious which ones I missed.

Thanks, and indeed it did. The remaining 5 patches have new versions posted.

>> This should hopefully make a very large dent in our bug/issue statistics.
> Absolutely!
>> > _______________________________________________
>> > Xen-devel mailing list
>> > Xen-devel@xxxxxxxxxxxxx
>> > http://lists.xen.org/xen-devel
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxx
>> http://lists.xen.org/xen-devel

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.