Re: [Xen-devel] [PATCH v4 2/3] xen/arm: Blacklist sun7i UARTs

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 1 November 2013 07:03, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> These are in the same page as the UART which is used as the Xen console. We 
> are
> not currently smart enough to avoid passing them through to the guest,
> accidentally giving the guest access to the Xen console UART.
>
> we blacklist them all, if necessary in the future we can split the list into
> two halves and make a per platform decision about which half should be
> blacklisted on a given platform depending on which UART is wired up as the
> console.
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

> ---
> v4: Blacklist all UARTs for the time being.
> ---
>  xen/arch/arm/platforms/sunxi.c |   11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/xen/arch/arm/platforms/sunxi.c b/xen/arch/arm/platforms/sunxi.c
> index ab3b4a6..b466518 100644
> --- a/xen/arch/arm/platforms/sunxi.c
> +++ b/xen/arch/arm/platforms/sunxi.c
> @@ -24,8 +24,19 @@ static const char * const sunxi_dt_compat[] __initconst =
>      NULL
>  };
>
> +static const struct dt_device_match sunxi_blacklist_dev[] __initconst =
> +{
> +    /*
> +     * The UARTs share a page which runs the risk of mapping the Xen console
> +     * UART to dom0, so don't map any of them.
> +     */
> +    DT_MATCH_COMPATIBLE("snps,dw-apb-uart"),
> +    { /* sentinel */ },
> +};
> +
>  PLATFORM_START(sunxi, "Allwinner A20")
>      .compatible = sunxi_dt_compat,
> +    .blacklist_dev = sunxi_blacklist_dev,
>  PLATFORM_END
>
>  /*
> --
> 1.7.10.4
>



-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel