[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] Fix sched_priv corruption in ARINC653 alloc_vdata.

On 11/1/2013 9:53 AM, Andrew Cooper wrote:
> On 31/10/13 20:47, Nathan Studer wrote:
>> From: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>
>> The ARINC653 scheduler was directly assigning and manipulating
>> the sched_priv field of a vcpu in its alloc_vdata function.
>> When creating a cpu pool, this resulted in the corruption
>> of the sched_priv field of the vcpu, which was then passed
>> to the initial scheduler's free_vdata function with
>> disastrous results.
>> Signed-off-by: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>
> This looks sane.
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> You have one line of misc whitespace change.  Given the extent of
> trailing whitespace in the file, it might be worth having a separate
> patch in the series which fixes all the whitespace at once.  Along with
> that, it would be kind to put a "Local variables" block in as well (see
> the bottom of sched.h as an example).

These patches just fix the immediate problem of the hypervisor crashing when
using the arinc653 scheduler in cpu pools.  I expect some more patches in the
near future to get pools fully working with the arinc653 scheduler, and since I
agree with your assessment, I can address this then.

Thanks for suggesting it.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.