[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] Call sched_destroy_domain before cpupool_rm_domain.

  • To: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Mon, 04 Nov 2013 07:30:10 +0100
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • Delivery-date: Mon, 04 Nov 2013 06:31:08 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Message-ID:Date:From:Organization:User-Agent: MIME-Version:To:CC:Subject:References:In-Reply-To: Content-Type:Content-Transfer-Encoding; b=MqrHSHaFgUFr7K1z5kEUMME6asSNyomeOu9NWzcFVuaxYrMWmqioz47h xGcbF/vQX9Qa5tve/H/95U5KkZySp+tw2x7R06DK2XgYH03U6eG/jLg8U ZGDukUO9js+PzNFjeoezzhz+lAQZUMIcxF7lecrPtakDgRmEAr1q5h0Fl yagxbhGmchPgiusqtw86XOc5DDhRFeUSVdTxnu/L0AhXJt240GmT9L9oD 0+1ceT/rxHKXHui/DGjzf6Bict4nw;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 04.11.2013 04:03, Nathan Studer wrote:
From: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>

The domain destruction code, removes a domain from its cpupool
before attempting to destroy its scheduler information.  Since
the scheduler framework uses the domain's cpupool information
to decide on which scheduler ops to use, this results in the
the wrong scheduler's destroy domain function being called
when the cpupool scheduler and the initial scheduler are

Correct this by destroying the domain's scheduling information
before removing it from the pool.

Signed-off-by: Nathan Studer <nate.studer@xxxxxxxxxxxxxxx>

Reviewed-by: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>

  xen/common/domain.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/common/domain.c b/xen/common/domain.c
index 5999779..78ce968 100644
--- a/xen/common/domain.c
+++ b/xen/common/domain.c
@@ -727,10 +727,10 @@ static void complete_domain_destroy(struct rcu_head *head)


-    cpupool_rm_domain(d);

+    cpupool_rm_domain(d);
      /* Free page used by xen oprofile buffer. */

Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 62060 2932
Fujitsu                                   e-mail: juergen.gross@xxxxxxxxxxxxxx
Mies-van-der-Rohe-Str. 8                Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.