[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [RFC 0/8] Improvements to HPET interupts

This patch series is very RFC.  Some parts of the series are for debugging
purposes only, but I am open to including them formally if people think they
might be useful.

I have done the best I can at splitting out changes from the final patch, but
have mostly failed at identifying areas which can be pulled out in a
compile/bisect-safe way.

The "no-arat" command line option introduced by the first patch is required
for sensible testing of the patch.  There is very little hardware around which
is old enough to not have ARAT, but has MSI capable HPET channels; Any newer
hardware which is ARAT-capable will unconditionally use TSC deadline mode.

As far as functional testing goes, I have put as many ASSERT()s in as I think
are necessary, and have tested on a variety of hardware with Xen as idle as I
can make it (not even dom0 running).  The proportion of time spent in certain
C states (as reported by the 'c' debugkey) is consistent before and after the
change, and nothing has blown up.

I would appreciate any advice on where I might be able to split up the final
patch to make it clearer, and comments on the design/implementation.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Keir Fraser <keir@xxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>

Andrew Cooper (8):
  x86/timing: Command line parameter to disable ARAT
  x86/acpi: Warn about multiple HPET tables
  x86/hpet: Fix ambiguity in broadcast info message.
  x86/hpet: Debug and verbose hpet logging
  x86/msi: Refactor msi_compose_message() to not requrie an irq_desc
  x86/hpet: Adjust pointer vs array semantics of hpet_boot_cfg
  x86/hpet: debug keyhandlers
  x86/hpet: Use singe apic vector rather than irq_descs for HPET

 xen/arch/x86/acpi/boot.c            |   11 +
 xen/arch/x86/cpu/amd.c              |    2 +-
 xen/arch/x86/cpu/common.c           |    3 +
 xen/arch/x86/cpu/cpu.h              |    2 +
 xen/arch/x86/cpu/intel.c            |    5 +-
 xen/arch/x86/hpet.c                 |  596 +++++++++++++++++------------------
 xen/arch/x86/msi.c                  |    9 +-
 xen/drivers/passthrough/vtd/iommu.c |    2 +-
 xen/include/asm-x86/msi.h           |    2 +-
 9 files changed, 318 insertions(+), 314 deletions(-)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.