[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH trivial] include: uapi: standard all files' macro prefix and suffix, excluding "linux/" sub-directory

On 11/05/2013 07:11 PM, David Howells wrote:
> Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
>>> Userspace sometimes depends on the name in the guard macro:-/
>> "the guard macro" is only for prevent itself from being included by
>> multiple times (an id used by itself -- like a handle), it is not an id
>> to let other files know about it (it is not a normal using way).
> Whilst that *should* be true, it isn't actually true.  See:
>       grep -r _LINUX_.*_H /usr/include/ | grep -v ^/usr/include/linux/
> for example.  Also who knows what all those autoconf scripts out there look
> for?

Oh... the real world is really not quite perfect. :-/

> However, thinking about it some more, you're probably safe with respect to
> userspace as scripts/headers_install.h strips off the _UAPI prefix on the
> guard macros - just as long as you don't change the rest of the macro name.

In honest, I really did not think more about it.

Only adding _UAPI (not touch others) can completely fix one style issue:
separate "uapi/*" from other sub-directories in "include/*"

So for me, we can continue improve this patch: add "_UAPI" for all guard
macro under "include/uapi/*" (also include "include/uapi/linux").

Chen Gang

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.