Re: [Xen-devel] [PATCH] libxl: Cleanup, use LOG*, GCSPRINTF and CTX macros in libxl_device.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-05 at 11:48 +0000, George Dunlap wrote:
> >   bad_format:
> > -    LIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "Disk vdev=%s, backend %s"
> > -               " unsuitable due to format %s",
> > -               a->disk->vdev,
> > -               libxl_disk_backend_to_string(backend),
> > -               libxl_disk_format_to_string(a->disk->format));
> > +    LOG(DEBUG, "Disk vdev=%s, backend %s unsuitable due to format %s",
> > +        a->disk->vdev,
> > +        libxl_disk_backend_to_string(backend),
> > +        libxl_disk_format_to_string(a->disk->format));
> 
> Given that in existing places, the LOG macro has formatted variables
> aligned to the beginning of the quote rather than to the open paren,

There's a bit of a mixture and the indented version is more prevalent.
But there's only 7 multiline uses of LOG* in that file (the split is 5:2
in favour of indentation).

I'd object to just reindenting but if the line is changing anyway I have
no strong feelings on the style used.

The non-indented variant does have the benefit that formatting helpers
(e.g. emacs' c-mode) do it that way for you...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel