Re: [Xen-devel] [PATCH RESEND 05/12] xen: numa-sched: make space for per-vcpu node-affinity

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.11.13 at 15:35, Dario Faggioli <dario.faggioli@xxxxxxxxxx> wrote:
> @@ -197,6 +199,13 @@ struct vcpu
>      /* Used to restore affinity across S3. */
>      cpumask_var_t    cpu_affinity_saved;
>  
> +    /*
> +     * Bitmask of CPUs on which this VCPU prefers to run. For both this
> +     * and auto_node_affinity access is serialized against
> +     * v->domain->node_affinity_lock.
> +     */
> +    cpumask_var_t    node_affinity;

This all looks quite sensible, except for the naming here: We
already have a node_affinity field in struct domain, having a
meaning that one can expect with this name. So you break
both consistency and the rule of least surprise here. How
about just "preferred_cpus"?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel