Re: [Xen-devel] [PATCH 2/3] libxl: event system: Make libxl_sigchld_owner_libxl_always work

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-05 at 19:19 +0000, Ian Jackson wrote:
> Previously, libxl_sigchld_owner_libxl_always was mishandled.  It would
> result in libxl paying no attention to the sigchld self pipe.
> 
> Fix this by fixing chldmode_ours so that it returns true iff we are
> supposed to be handling SIGCHLD.
> 
> Additionally, we arrange to use chldmode_ours everywhere where we are
> installing/removing signal handlers and/or deciding whether to check
> the self pipe, etc.  This means it needs a new "creating" flag
> argument for the benefit of libxl__ev_child_fork, which needs to
> install the signal handler in libxl_sigchld_owner_libxl even if there
> are not currently any children.
> 
> ctx->childproc_hooks->chldowner is now interpreted only by
> chldmode_ours.
> 
> Reported-by: Bamvor Jian Zhang <bjzhang@xxxxxxxx>
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Bamvor Jian Zhang <bjzhang@xxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel