Re: [Xen-devel] [PATCH] kexec: don't disable interrupts when acquiring load/unload lock

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 06/11/13 14:17, Jan Beulich wrote:
>>>> On 06.11.13 at 14:20, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
>> On 06/11/13 12:22, Jan Beulich wrote:
>>> This doesn't appear to have served any purpose other than causing
>>> map_pages_to_xen() to be (incorrectly) invoked with interrupts
>>> disabled. In particular, serialization against actual kexec-ing is done
>>> without this lock being involved. Clarify the scope of the lock at once
>>> by making it local to do_kexec_op_internal().
>>>
>>> Once at it, also drop a pointless initializer.
>>
>> I've already dropped the irqsave from this lock in my kexec series and
>> can fold the other part in as well (which would now be in
>> kexec_swap_images()).
> 
> That would generally be fine, but I'd like to get this fixed no matter
> whether your patches make 4.4.

Sure. I was only asking if you could wait a few days.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel