[Xen-devel] [PATCH v4 22/27] libxl: ocaml: add disk and cdrom helper functions

[Rob Hoes <rob.hoes@xxxxxxxxxx>]

Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
Acked-by: David Scott <dave.scott@xxxxxxxxxxxxx>

---
v4: Added libxl_device_disk_dispose.
---
 tools/ocaml/libs/xl/genwrap.py       |   17 +++++++-----
 tools/ocaml/libs/xl/xenlight_stubs.c |   50 ++++++++++++++++++++++++++++++----
 2 files changed, 55 insertions(+), 12 deletions(-)

diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py
index 320a6e0..7a9f498 100644
--- a/tools/ocaml/libs/xl/genwrap.py
+++ b/tools/ocaml/libs/xl/genwrap.py
@@ -26,18 +26,21 @@ DEVICE_FUNCTIONS = [ ("add",            ["ctx", "t", 
"domid", "?async:'a", "unit
                      ("remove",         ["ctx", "t", "domid", "?async:'a", 
"unit", "unit"]),
                      ("destroy",        ["ctx", "t", "domid", "?async:'a", 
"unit", "unit"]),
                    ]
+DEVICE_LIST =      [ ("list",           ["ctx", "domid", "t list"]),
+                   ]
 
 functions = { # ( name , [type1,type2,....] )
     "device_vfb":     DEVICE_FUNCTIONS,
     "device_vkb":     DEVICE_FUNCTIONS,
-    "device_disk":    DEVICE_FUNCTIONS,
-    "device_nic":     DEVICE_FUNCTIONS +
-                      [ ("list",           ["ctx", "domid", "t list"]),
-                        ("of_devid",       ["ctx", "domid", "int", "t"]),
+    "device_disk":    DEVICE_FUNCTIONS + DEVICE_LIST +
+                      [ ("insert",         ["ctx", "t", "domid", "?async:'a", 
"unit", "unit"]),
+                        ("of_vdev",        ["ctx", "domid", "string", "t"]),
+                      ],
+    "device_nic":     DEVICE_FUNCTIONS + DEVICE_LIST +
+                      [ ("of_devid",       ["ctx", "domid", "int", "t"]),
                       ],
-    "device_pci":     DEVICE_FUNCTIONS +
-                      [ ("list",              ["ctx", "domid", "t list"]),
-                        ("assignable_add",    ["ctx", "t", "bool", "unit"]),
+    "device_pci":     DEVICE_FUNCTIONS + DEVICE_LIST +
+                      [ ("assignable_add",    ["ctx", "t", "bool", "unit"]),
                         ("assignable_remove", ["ctx", "t", "bool", "unit"]),
                         ("assignable_list",   ["ctx", "t list"]),
                       ],
diff --git a/tools/ocaml/libs/xl/xenlight_stubs.c 
b/tools/ocaml/libs/xl/xenlight_stubs.c
index e67e499..2c2b3fd 100644
--- a/tools/ocaml/libs/xl/xenlight_stubs.c
+++ b/tools/ocaml/libs/xl/xenlight_stubs.c
@@ -395,7 +395,7 @@ void async_callback(libxl_ctx *ctx, int rc, void 
*for_callback)
 #define _STRINGIFY(x) #x
 #define STRINGIFY(x) _STRINGIFY(x)
 
-#define _DEVICE_ADDREMOVE(type,op)                                     \
+#define _DEVICE_ADDREMOVE(type,fn,op)                                  \
 value stub_xl_device_##type##_##op(value ctx, value info, value domid, \
        value async, value unit)                                        \
 {                                                                      \
@@ -411,7 +411,7 @@ value stub_xl_device_##type##_##op(value ctx, value info, 
value domid,      \
                ao_how.u.for_callback = (void *) Some_val(async);       \
        }                                                               \
                                                                        \
-       ret = libxl_device_##type##_##op(CTX, Int_val(domid), &c_info,  \
+       ret = libxl_##fn##_##op(CTX, Int_val(domid), &c_info,           \
                async != Val_none ? &ao_how : NULL);                    \
                                                                        \
        libxl_device_##type##_dispose(&c_info);                         \
@@ -423,15 +423,16 @@ value stub_xl_device_##type##_##op(value ctx, value info, 
value domid,    \
 }
 
 #define DEVICE_ADDREMOVE(type) \
-       _DEVICE_ADDREMOVE(type, add) \
-       _DEVICE_ADDREMOVE(type, remove) \
-       _DEVICE_ADDREMOVE(type, destroy)
+       _DEVICE_ADDREMOVE(type, device_##type, add) \
+       _DEVICE_ADDREMOVE(type, device_##type, remove) \
+       _DEVICE_ADDREMOVE(type, device_##type, destroy)
 
 DEVICE_ADDREMOVE(disk)
 DEVICE_ADDREMOVE(nic)
 DEVICE_ADDREMOVE(vfb)
 DEVICE_ADDREMOVE(vkb)
 DEVICE_ADDREMOVE(pci)
+_DEVICE_ADDREMOVE(disk, cdrom, insert)
 
 value stub_xl_device_nic_of_devid(value ctx, value domid, value devid)
 {
@@ -472,6 +473,45 @@ value stub_xl_device_nic_list(value ctx, value domid)
        CAMLreturn(list);
 }
 
+value stub_xl_device_disk_list(value ctx, value domid)
+{
+       CAMLparam2(ctx, domid);
+       CAMLlocal2(list, temp);
+       libxl_device_disk *c_list;
+       int i, nb;
+       uint32_t c_domid;
+
+       c_domid = Int_val(domid);
+
+       c_list = libxl_device_disk_list(CTX, c_domid, &nb);
+       if (!c_list)
+               failwith_xl(ERROR_FAIL, "disk_list");
+
+       list = temp = Val_emptylist;
+       for (i = 0; i < nb; i++) {
+               list = caml_alloc_small(2, Tag_cons);
+               Field(list, 0) = Val_int(0);
+               Field(list, 1) = temp;
+               temp = list;
+               Store_field(list, 0, Val_device_disk(&c_list[i]));
+               libxl_device_disk_dispose(&c_list[i]);
+       }
+       free(c_list);
+
+       CAMLreturn(list);
+}
+
+value stub_xl_device_disk_of_vdev(value ctx, value domid, value vdev)
+{
+       CAMLparam3(ctx, domid, vdev);
+       CAMLlocal1(disk);
+       libxl_device_disk c_disk;
+       libxl_vdev_to_device_disk(CTX, Int_val(domid), String_val(vdev), 
&c_disk);
+       disk = Val_device_disk(&c_disk);
+       libxl_device_disk_dispose(&c_disk);
+       CAMLreturn(disk);
+}
+
 value stub_xl_device_pci_list(value ctx, value domid)
 {
        CAMLparam2(ctx, domid);
-- 
1.7.10.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel