Re: [Xen-devel] [PATCH v14 05/17] pvh: Introduce PVH guest type

[Tim Deegan <tim@xxxxxxx>]

At 12:14 +0000 on 04 Nov (1383563694), George Dunlap wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -239,6 +239,17 @@ struct domain *domain_create(
>  
>      if ( domcr_flags & DOMCRF_hvm )
>          d->guest_type = guest_type_hvm;
> +    else if ( domcr_flags & DOMCRF_pvh )
> +    {
> +        if ( !(domcr_flags & DOMCRF_hap) )
> +        {
> +            err = -EOPNOTSUPP;
> +            printk(XENLOG_INFO "PVH guest must have HAP on\n");
> +            goto fail;
> +        }
> +        d->guest_type = guest_type_pvh;
> +        printk("Creating PVH guest d%d\n", d->domain_id);
> +    }

This check seems like it should be in arch-specific code.  If it
were in arch_domain_create(), it would also correctly handle the
case where the tools asked for PVH+HAP but HAP wasn't available. 

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel