Re: [Xen-devel] [PATCH v14 07/17] pvh: vmx-specific changes

[Tim Deegan <tim@xxxxxxx>]

At 16:42 +0000 on 04 Nov (1383579750), Jan Beulich wrote:
> >>> On 04.11.13 at 13:14, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > +    if ( is_pvh_domain(d) )
> > +        v->arch.hvm_vmx.vmx_realmode = 0;
> 
> Rather than doing this here, wouldn't it be more clean to suppress
> this getting set to 1 in the first place?

I think this can probably just be dropped -- the call to
hvm_update_guest_cr(v, 0) above should have DTRT with the vmx_realmode
flag.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel