Re: [Xen-devel] [PATCH v2 01/12] xenctx: Clean up stack trace when hypercall_page not in symbol table

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.11.13 at 21:08, Don Slutz <dslutz@xxxxxxxxxxx> wrote:
> From: Don Slutz <Don@xxxxxxxxxxxxxxx>
> 
> Before:
> 
> Call Trace:
>   [<ffffffff8006b2b0>] default_idle+0x29  <--
>   [<ffffffff80048d19>] cpu_idle+0x95
>   [<ffffffff803e7801>] start_kernel+0x220
>   [<0000000000000000>] startup_64+0x80000000
>   [<ffffffff803e722f>] x86_64_start_kernel+0x22f
>   [<0000000000000000>] startup_64+0x80000000
>   [<0000000000000000>] startup_64+0x80000000
>   [<0000000000000000>] startup_64+0x80000000
>   [<0000000000000000>] startup_64+0x80000000
> 
> After:
> 
> Call Trace:
>   [<ffffffff8006b2b0>] default_idle+0x29  <--
>   [<ffffffff80048d19>] cpu_idle+0x95
>   [<ffffffff803e7801>] start_kernel+0x220
>   [<ffffffff803e722f>] x86_64_start_kernel+0x22f
> 
> Signed-off-by: Don Slutz <Don@xxxxxxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

And a note on patch submission: You send _to_ the list, and _cc_
maintainers and other relevant people (without stretching the
meaning of "relevant" too much).

Jan

> ---
>  tools/xentrace/xenctx.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/xentrace/xenctx.c b/tools/xentrace/xenctx.c
> index 060e480..10292fa 100644
> --- a/tools/xentrace/xenctx.c
> +++ b/tools/xentrace/xenctx.c
> @@ -83,8 +83,9 @@ static int is_kernel_text(guest_word_t addr)
>      if (addr >= kernel_stext &&
>          addr <= kernel_etext)
>          return 1;
> -    if (addr >= kernel_hypercallpage &&
> -        addr <= kernel_hypercallpage + 4096)
> +    if (kernel_hypercallpage &&
> +        (addr >= kernel_hypercallpage &&
> +         addr <= kernel_hypercallpage + 4096))
>          return 1;
>      if (addr >= kernel_sinittext &&
>          addr <= kernel_einittext)
> -- 
> 1.7.1




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel