Re: [Xen-devel] [PATCH RESEND 11/12] xl: numa-sched: enable getting/specifying per-vcpu node-affinity

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Dario Faggioli writes ("[PATCH RESEND 11/12] xl: numa-sched: enable 
getting/specifying per-vcpu node-affinity"):
> by showing it, upon request ('-n' switch), as a part of the
> output of `xl vcpu-list'. Such output looks like this:
...
> # xl vcpu-list -n
> 
> Name          ID  VCPU   CPU State   Time(s) CPU Affinity / NUMA Affinity
> Domain-0       0     0    8   -b-       4.4  any cpu / any node
> Domain-0       0     1    0   -b-       1.2  any cpu / any node
> vm-test        1     0    8   -b-       2.4  any cpu / 1
> vm-test        1     1   13   -b-       3.3  any cpu / 1
> 
> The "vcpu-pinning / vcpu-affinity" part may indeed look
> weird, as it is different from the other fields.
> Unfortunately, it's very hard to properly format it in
> columns, since there is no such things as minimal or
> maximal lengths for the bitmaps being printed.

Can you use the same syntax for printing as would be legal in
the config file ?

> While at it, the implementation of `xl vcpu-list' is reworked
> a little bit, making it more similar to the one of `xl list'
> and more compliant with the libxl programming paradigm (e.g.,
> regarding allocating at the beginning and freeing on exit).

Can you do this in a pre-patch ?

> xl manual page is updated accordingly.

> -static int update_cpumap_range(const char *str, libxl_bitmap *cpumap)
> +static int update_bitmap_range(const char *str, libxl_bitmap *bitmap)

I don't understand how this set of changes relates to this patch.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel