[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 11/12] xenctx: Dump registers via hvm info if available.

On Fri, 2013-11-08 at 10:29 +0000, Andrew Cooper wrote:
> On 08/11/13 10:13, Ian Campbell wrote:
> > On Thu, 2013-11-07 at 13:56 -0500, Don Slutz wrote:
> >> On 11/06/13 15:35, Andrew Cooper wrote:
> >>> I would certainly not object if someone were to merge these two tools
> >>> into one.  It is particularly awkward as xen-hvmctx ends up being
> >>> installed into /usr/sbin/ and is therefore on the $PATH, while xenctx
> >>> ends up off the $PATH in /usr/lib/xen/bin/
> >> The way I would do this is to make 1 source file, delete the 2nd, and
> >> install the same code as both xenctx and xen-hvmctx.  argv[0] can be
> >> decoded and the default action adjusted based on the name. In this
> >> case there would be command line options to get the current old output
> >> for each tool.
> > Personally I don't think we need to retain any kind of CLI compatibility
> > for such developer focused tools. I'd be perfectly happy for the
> > (sensible) functionality of hvmctx to be merged into xenctx and to then
> > disappear.
> >
> > Ian.
> >
> Agreed - I would much prefer one single tool with a useful set of
> options rather than keeping around something which vaguely looks like an
> older tool for the sake of it.
> This is strictly a dev tool rather than production tool.

Right. and on that basis In the short term while this is being sorted
out I'd be happy with a patch to move hvmctx into LIBDIR instead of
SBINDIR too, so it is less prominent.

(the question of whether xenctx really belongs in $PATH or not is one we
can consider separately later...)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.