[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/5] x86/hpet: Pre cleanup

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: David Vrabel <david.vrabel@xxxxxxxxxx>
Date: Mon, 11 Nov 2013 10:49:06 +0000
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Tim Deegan <tim@xxxxxxx>
Delivery-date: Mon, 11 Nov 2013 10:49:17 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 08/11/13 10:37, Andrew Cooper wrote:
> 
> So what would you suggest?  Here, all the __$foo() are designed to end
> up similar to large swathes of other Xen code, implying that the
> appropriate spinlock should be held by the caller.
> 
> I am not too fussed which convention we use, so long as it is used
> consistently.

I've sometimes used a _locked suffix for this.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

References:
- [Xen-devel] [RFC v2 0/5] HPET fix interrupt logic
  - From: Andrew Cooper
- [Xen-devel] [PATCH v2 1/5] x86/hpet: Pre cleanup
  - From: Andrew Cooper
- Re: [Xen-devel] [PATCH v2 1/5] x86/hpet: Pre cleanup
  - From: Jan Beulich
- Re: [Xen-devel] [PATCH v2 1/5] x86/hpet: Pre cleanup
  - From: Andrew Cooper

Prev by Date: Re: [Xen-devel] Is there an issue with turning off "scrubbing free RAM" on boot with Xen 4.1.3
Next by Date: Re: [Xen-devel] [PATCH] gnttab: lock the left grant table earlier in __gnttab_unmap_common()
Previous by thread: Re: [Xen-devel] [PATCH v2 1/5] x86/hpet: Pre cleanup
Next by thread: [Xen-devel] [PATCH v2 5/5] x86/hpet: debug keyhandlers
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.