Re: [Xen-devel] [PATCH 1/2] opw: libxl: add convenience macros to qmp_send() in libxl_qmp.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-11-11 at 02:08 -0800, Kelley Nielsen wrote:
> Update qmp_send() in libxl_qmp.c to use the new convenience macros
> declared in libxl_internal.h. Uses GC_INIT at the top of the function,
> and GC_FREE at the exit. Since GC_INIT returns a libxl__gc by reference
> and not by value, remove the address operator from the left of the
> variable gc where it is passed as a parameter.
> 
> Signed-off-by: Kelley Nielsen <kelleynnn@xxxxxxxxx>
> Suggested-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

I'm dubious about whether qmp_send should be creating itself a gc rather
than receiving one as a parameter, but given that it does it should use
the macros:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

and committed.

(NB, the tag things are more normally chronological, i.e. suggested-by
first, then s-o-b, hence I reordered upon commit).

(NB2, I think the OPW tag isn't so useful for the actual commit log,
inside the patch prefix i.e. [PATCH OPW ...] would be better, git
send-email --subject-preifx='PATCH OPW' would do the trick)

Ian



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel