Re: [Xen-devel] [PATCH] opw: libxl: LOGE() used in place of LIBXL__LOG_ERROR in libxl_qmp.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2013-11-09 at 20:56 -0800, Kelley Nielsen wrote:
> Code cleanup -- no functional changes
> 
> Coding style has recently been changed for libxl. The convenience
> macro LOGE() has been introduced, and invocations of the old macro
> LIBXL__LOG_ERROR() are to be replaced with it. Change all occurences
> of the old macro (in functions that have a local libxl_gc *gc) except
> the one in register_serials_chardev_callback() to the new one. (This
> function lacks a local libxl__gc *gc, which LOGE() requires.)
> 
> Signed-off-by: Kelley Nielsen <kelleynnn@xxxxxxxxx>
>      if (unlink(qmp_socket) == -1) {
>          if (errno != ENOENT) {
> -            LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR,
> -                             "Failed to remove QMP socket file %s",
> +            LOGE(ERROR, "Failed to remove QMP socket file %s",
>                               qmp_socket);

When making these sorts of changes please reindent the subsequent lines
containing the parameters to align to the new location of the "(". Or in
this case it very likely makes sense to unwrap it all onto one line, if
it is less that 80 columns (I didn't count).

BTW there was a trivial conflict with your previous "opw: libxl: macro
LOG() used in place of LIBXL__LOG" change, which suggests this would
have been better done as a series of patches building on each other.

Thanks,
Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel