Re: [Xen-devel] [PATCH 3/4] opw: libxl: use LOG and LOGE instead of LIBXL__LOG* in libxl_utils.c

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2013-11-10 at 23:08 -0800, Kelley Nielsen wrote:
> Code cleanup - no functional changes
> 
> The convenience macros LOG and LOGE have been written to take the
> place of the old macros in the LIBXL__LOG* family. Replace the
> invocations of the old macros in the function libxl_read_file_contents()
> with invocations of the corresponding new ones. Create a local
> libxl__gc gc* for the new macros to use by invoking GC_INIT(ctx) at the
> top of the function, and clean it up by invoking GC_FREE at the two
> exit points.

In this case adding the GC_INIT was the correct approach, thanks.

>              else if (feof(f))
> -                LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "%s changed size while we"
> +                LOG(ERROR, "%s changed size while we"
>                         " were reading it", filename);

Please unwrap or reindent this one. With that changed:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel