[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2-resend 22/30] libxl: ocaml: event management [and 1 more messages]

Rob Hoes writes ("[PATCH v4 18/27] libxl: ocaml: event management"):
> Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
> Acked-by: David Scott <dave.scott@xxxxxxxxxxxxx>
> ---
>  tools/ocaml/libs/xl/xenlight.ml.in   |   66 +++++++
>  tools/ocaml/libs/xl/xenlight.mli.in  |   47 +++++
>  tools/ocaml/libs/xl/xenlight_stubs.c |  325 
> ++++++++++++++++++++++++++++++++++

I replied to v2 of this as follows:

Ian Jackson writes ("Re: [Xen-devel] [PATCH v2-resend 22/30] libxl: ocaml: 
event management"):
> Can you explain in a bit more detail how you expect to use this ?
> I'm very surprised that apparently the right interface to provide is
> one which exposes the poll-based event loop machinery to ocaml.
> Surely it would be better to plumb that in at a lower level.

But I haven't had an answer.

I think that whether this is the right approach depends on how event
loops are traditionally done in ocaml.

I'm afraid, though, that in the absence of an explanation:

Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


PS Does anyone here know how Mirage handles event loops ?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.