[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] events/fifo: don't corrupt queues if an old tail moves queues

>>> On 11.11.13 at 17:03, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
> +static bool_t test_and_set_linked(struct domain *d, struct evtchn *evtchn,

Same comment here regarding constification of d.

> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -98,6 +98,8 @@ struct evtchn
>      } u;
>      u8 priority;
>      u8 pending:1;
> +    u16 last_vcpu_id;
> +    u8 last_priority;

So this adds up to 5 bytes now, whereas you apparently could do
with 4. On ARM this means the structure is larger than needed; on
64-bit (ARM or x86) it means that further additions are going to
be less obvious. I'd therefore suggest

    } u;
    u16 last_vcpu_id;
    u8 priority:4;
    u8 last_priority:4;
    u8 pending:1;


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.