Re: [Xen-devel] [PATCH] xen/arm: correct duplicate MPIDR check to actually skip the node

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 11/11/2013 04:10 PM, Ian Campbell wrote:
> On Fri, 2013-11-08 at 13:32 +1300, Matthew Daley wrote:
> > Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
> > ---
> > I assume this was what was really intended...
Indeed, that for spotting this error !

> CCing Julien... But yes it looks like it.
>
> >   xen/arch/arm/smpboot.c |    4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> > index b836be4..6c90fa6 100644
> > --- a/xen/arch/arm/smpboot.c
> > +++ b/xen/arch/arm/smpboot.c
> > @@ -161,9 +161,11 @@ void __init smp_init_cpus(void)
> >                   printk(XENLOG_WARNING
> >                          "cpu node `%s`: duplicate /cpu reg properties in the 
> > DT\n",
> >                          dt_node_full_name(cpu));
> > -                continue;
> > +                break;
> >               }
> >           }
> > +        if ( j != cpuidx )
> > +            continue;
> Took me a moment to figure out what this was for. I'm half minded to
> suggest this is one of those places where a "goto next_cpu" would have
> been ok, I'd definitely want a second opinion on that though!
I'm happy with the both solutions:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel