[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: Initial Broadcom A15 platform support

On 11/12/2013 09:57 AM, Ian Campbell wrote:
On Mon, 2013-11-11 at 20:37 +0000, Julien Grall wrote:
+    for (cpu = 1; cpu < 4; cpu++) {
+        rc = brcm_cpu_power_on(va, cpu);
+        if (rc)
+            break;
+    }

I don't like the for loop on the cores. In the future, it's possible
that Xen decides to only use 2 cores, so you will power unused core.
What about enabling power in brcm_cpu_up, if it's not too late?

Not only in the future, we have command line options for these sorts of
things already, which I think the ARM port obeys.

Are you talking about "max_cpus" parameter? If so, it's not yet implemented on ARM. We rely on the number of cpus node in the device tree.

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.