Re: [Xen-devel] [PATCH] blkif: add indirect descriptors interface to public headers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 12/11/13 15:49, David Vrabel wrote:
> On 12/11/13 14:43, Jan Beulich wrote:
>>>>> On 12.11.13 at 15:12, David Vrabel <david.vrabel@xxxxxxxxxx> wrote:
>>> On 12/11/13 13:46, Paul Durrant wrote:
>>>>> +};
>>>>> +typedef struct blkif_request_indirect blkif_request_indirect_t;
>>>>> +
>>>>> +struct blkif_request_segment_aligned {
>>>>> +    grant_ref_t gref;            /* reference to I/O buffer frame        
>>>>> */
>>>>> +    /* @first_sect: first sector in frame to transfer (inclusive).   */
>>>>> +    /* @last_sect: last sector in frame to transfer (inclusive).     */
>>>>> +    uint8_t     first_sect, last_sect;
>>>
>>> Missing uint8_t padding here?
>>
>> Note that there are _two_ uint8_t-s.
> 
> Doh. That's poor style though.   A line per field, please.

I've mainly did it that way because that's how blkif_request_segment is
currently defined in blkif.h, but I can split it in two lines.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel