Re: [Xen-devel] [V1 PATCH 07/11] PVH dom0: implement XENMEM_add_to_physmap_range for x86

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.13 at 02:23, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> @@ -4522,7 +4522,8 @@ static int handle_iomem_range(unsigned long s, unsigned 
> long e, void *p)
>  
>  static int xenmem_add_to_physmap_once(
>      struct domain *d,
> -    const struct xen_add_to_physmap *xatp)
> +    const struct xen_add_to_physmap *xatp,
> +    domid_t foreign_domid)

I continue to be confused by this parameter being added, but not
being used. I can only repeat - logically consistent pieces please.
At least from looking at the patch alone, a user of
XENMEM_add_to_physmap_range will, after this patch, not get
what it is supposed to get.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel