Re: [Xen-devel] [PATCH RESEND] libxl: Deprecate synchronous waiting for the device model

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH RESEND] libxl: Deprecate synchronous waiting 
for the device model"):
> On Tue, 2013-11-12 at 16:58 +0000, Ian Jackson wrote:
> > From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Date: Mon, 14 Oct 2013 17:26:01 +0100
> > Subject: [PATCH] libxl: Deprecate synchronous waiting for the device model
> > 
> > libxl__wait_for_device_model blocks, with the ctx lock held, waiting
> > for a response from the device model.  If the dm doesn't respond
> > quickly (for example, because it has crashed), this may block the
> > whole process.  Explain this in a comment, rename the function to
> > libxl__wait_for_device_model_deprecated, and explain what to use
> > instead.
> > 
> > libxl__wait_for_offspring is the core implementation for the above.
> > Its name leads people to think it might be generally useful for
> > waiting for children, which is far from the case.  It only waits for
> > xenstore.  Also it has the problems described above.  Explain this,
> > rename it to libxl__xenstore_child_wait_deprecated, and explain what
> > to use instead.
> > 
> > Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel