[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] BUG 4.2.2: xl cd-insert corrupts xenstore state

Ian Jackson writes ("Re: BUG 4.2.2: xl cd-insert corrupts xenstore state"):
> George Dunlap writes ("Re: BUG 4.2.2: xl cd-insert corrupts xenstore state"):
> > Turns out I already fixed this once!
> > 
> > commit c3556e2a1aee3c9b7dda5d57e85e8867fff1b9da
> > Author: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > Commit: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Here's the backport, which was nearly trivial.
> I'll push this to 4.2 staging unless someone objevts.

I have now done this.  Sorry for the delay.

> commit 1eea2f30f79a1af817fe32c9e01673da1f31dd5f
> Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Date:   Wed May 1 16:56:54 2013 +0100
>     libxl: Fix bug in libxl_cdrom_insert, make more robust against bad 
> xenstore data
>     libxl_cdrom_insert was failing to initialize the backend type,
>     resulting in the wrong default backend.  The result was not only that
>     the CD was not inserted properly, but also that some improper xenstore
>     entries were created, causing further block commands to fail.
>     This patch fixes the bug by setting the disk backend type based on the
>     type of the existing device.
>     It also makes the system more robust by checking to see that it has
>     got a valid path before proceeding to write a partial xenstore entry.
>     Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>     Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>     Committed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>     (cherry picked from commit c3556e2a1aee3c9b7dda5d57e85e8867fff1b9da)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.