Re: [Xen-devel] [PATCH RESEND v5 3/6] xen/arm: Implement modify_returncode

[Eugene Fedotov <e.fedotov@xxxxxxxxxxx>]

12.11.2013 19:24, Ian Campbell ÐÐÑÐÑ:
> On Fri, 2013-11-08 at 16:50 +0900, Jaeyong Yoo wrote:
> > From: Alexey Sokolov <sokolov.a@xxxxxxxxxxx>
> >
> > Making sched_op in do_suspend (driver/xen/manage.c) returns 0 on the success of 
> > suspend.
> >
> > Singed-off-by: Alexey Sokolov <sokolov.a@xxxxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> Although if you wanted to...
> > +#elif defined(__arm__)
> make this "... || defined(__aarch64__)" and ...
> > +    ctxt.c.user_regs.r0_usr = 1;
> Use x0 here instead (which is a 64-bit alias of r0_usr, so good for both
> 32 and 64 bit).
>
> Then it would be ready made for 64-bit too in the future.
>
> Ian.
Good point, OK.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel