Re: [Xen-devel] [PATCH v4 13/17] libxc: arm: allow passing a device tree blob to the guest

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-11-12 at 19:37 +0000, Stefano Stabellini wrote:
> On Tue, 12 Nov 2013, Ian Campbell wrote:
> > @@ -916,6 +950,25 @@ int xc_dom_build_image(struct xc_dom_image *dom)
> >              memcpy(ramdiskmap, dom->ramdisk_blob, dom->ramdisk_size);
> >      }
> >  
> > +    /* load devicetree */
> > +    if ( dom->devicetree_blob )
> > +    {
> > +        void *devicetreemap;
> > +
> > +        if ( xc_dom_alloc_segment(dom, &dom->devicetree_seg, "devicetree",
> > +                                  dom->devicetree_seg.vstart,
> > +                                  dom->devicetree_size) != 0 )
> > +            goto err;
> > +        devicetreemap = xc_dom_seg_to_ptr(dom, &dom->devicetree_seg);
> > +        if ( devicetreemap == NULL )
> > +        {
> > +            DOMPRINTF("%s: xc_dom_seg_to_ptr(dom, &dom->devicetree_seg) => 
> > NULL",
> > +                      __FUNCTION__);
> > +            goto err;
> > +        }
> > +        memcpy(devicetreemap, dom->devicetree_blob, dom->devicetree_size);
> 
> flush dcache?

We don't do so for the initrd or the kernel image, and in any case this
is user space (and common code) so I don't know how we can do so.

IIRC Julien was working on a generic solution for this issue.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel