[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: Don't call init_domheap_page with an empty range

On Wed, 2013-11-13 at 12:59 +0000, Julien Grall wrote:
> On 11/13/2013 10:45 AM, Ian Campbell wrote:
> > On Tue, 2013-11-12 at 21:42 +0000, Julien Grall wrote:
> >> When an initrd is given to xen by U-boot, it will reserve the memory in
> >> the device tree.
> >> In this case, when xen decides to free unused memory, dt_unreserved_regions
> >> will call init_domheap_page with the start and the end of range equals. But
> >> the latter assumes that (start > end), if not Xen will hang because the
> >> number of pages is equals to (unsigned)-1.
> >
> > init_xenheap_pages starts with "if (pe<=ps) return". I think
> > init_domheap_pages usefully do the same.

oops:                 ^could 

> Actually, init_domheap_pages doesn't contain this fix.

Yeah, I missed a word out, sorry!

>I will rework  this patch to move the check in this function.



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.