[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3] xen: Check if the range is valid in init_domheap_pages

On 13/11/2013 13:37, "Julien Grall" <julien.grall@xxxxxxxxxx> wrote:

> On ARM, when an initrd is given to xen by U-boot, it will reserve the memory
> in
> the device tree.
> In this case, when xen decides to free unused memory, dt_unreserved_regions
> will call init_domheap_pages with the start and the end of range equals. But
> the latter assumes that (start > end), if not Xen will hang because the
> number of pages is equals to (unsigned)-1.
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> CC: Keir Fraser <keir@xxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>

I understand Jan's reservations, but I think just being more liberal here is
fine really.

Acked-by: Keir Fraser <keir@xxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.