[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 19/19] libxl: build a device tree for ARM guests

On 11/14/2013 08:28 AM, Ian Campbell wrote:
On Thu, 2013-11-14 at 01:04 +0000, Julien Grall wrote:
Why didn't you try to use fdt_open_into? It should fit our usage: ie,
grow up the size of the device tree. Actually, DTC uses this solution
when the fdt needs to be resized.

It seemed to be far more complex -- you would need to wrap every
potentially failing fdt operation in a while loop which does the realloc
and open into on ENOSPACE. Now that could be done by a macro but it
would need to have much wider scope than here since it would be needed
all the way down the call chain.

This way the functions building each node don't need to worry about all
that and only the toplevel needs to care. I'd be in favour of increasing
the default allocation size before I wanted to switch the mechanism like

Ok. Then:

Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.