Re: [Xen-devel] [PATCH v2 11/16] libxc: get and set soft and hard affinity

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On gio, 2013-11-14 at 15:38 +0000, George Dunlap wrote:
> On 13/11/13 19:12, Dario Faggioli wrote:
> > by using the new flag introduced in the parameters of
> > DOMCTL_{get,set}_vcpuaffinity.
> >
> > This happens in two new xc calls: xc_vcpu_setaffinity_hard()
> > and xc_vcpu_setaffinity_soft() (an in the corresponding
> > getters, of course).
> 
> Personally I think:
> * You should be able to set both HARD and SOFT flags, in which case it 
> will set both hard and soft affinities
>
Ok. Just to be sure, you mean that, if I specify both flags, both hard
and soft affinity will be set to the same cpumap, right?

> * You should expose the "flags" to the xc caller, so that the caller can 
> set either one or both.
> 
Ok.

> > The existing xc_vcpu_{set,get}affinity() call is also retained,
> > with the following behavior:
> >
> >   * xc_vcpu_setaffinity() sets both the hard and soft affinity;
> >   * xc_vcpu_getaffinity() gets the hard affinity.
> >
> > This is mainly for backward compatibility reasons, i.e., trying
> > not to break existing callers/users.
> 
> The xc interface isn't stable, right?  Couldn't we just change the 
> callers (presumably just xend and libxl)?
>
In tree, yes, those ones plus something in
tools/ocaml/libs/xc/xenctrl_stubs.c.

I'll do it that way.

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel