[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] blkif: add indirect descriptors interface to public headers
On 14/11/13 20:16, Paul Durrant wrote:
>>> If it is the Linux one which of the fields is messed up? The whole struct
>>> (including the extra uint8 cmd) should be exactly 64 bytes.
>>>
>>> I am pretty sure we double checked that.
>>
>> How can this possibly be the same between 32-bit and 64-bit builds (unless
>> CONFIG_X86_64 is defined in both
>> cases)? And the fact that nr_segments won't be naturally aligned is pretty
>> bad too.
>
> D'oh, I missed the pad at the end, so they are the same size but that doesn't
> stop the layout being different and hence needing to make sure the ABI is set
> correctly in xenstore.
You already need to set the correct ABI in xenstore, or nothing is going
to work, normal non-indirect requests also have different sizes and offsets.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
