Re: [Xen-devel] [PATCH v4] libxl: spice usbredirection support for upstream qemu

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 15/11/13 10:32, Fabio Fantoni wrote:
> Il 12/11/2013 13:41, Stefano Stabellini ha scritto:
> > On Fri, 11 Oct 2013, Fabio Fantoni wrote:
> > > Usage: spiceusbredirection=NUMBER (default=0)
> > >
> > > Enables spice usbredirection. Creates NUMBER usbredirection channels
> > > for redirection of up to 4 usb devices from spice client to domU's 
> > > qemu.
> > > It requires an usb controller and if not defined will automatically 
> > > adds
> > > an usb2 controller.
> > >
> > > Changes from v3:
> > > - fixed condition that enable usbversion if it isn't defined in 
> > > presence
> > >    of usbredirection enabled
> > >
> > > Changes from v2:
> > > - updated for usbversion patch v7
> > > - now usbredirection cannot be used with usb and usbdevice parameters
> > > - if usbversion is undefined it will creates an usb2 controller
> > >
> > > Changes from v1:
> > > - Now can be setted the number of redirection channels.
> > > - Various code improvements.
> > >
> > > Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> > It looks correct from the QEMU arguments POV
> Thanks for reply, could someone review it and give approval for xen 
> 4.4 if possible?
It looks like this patch depends on the usb2/3 patch you have posted 
separately.  Having to keep track of which patch depends on what -- 
particularly if they have different versions, as we have here -- makes 
it much more difficult for maintainers to figure out what's going on; 
that tends to make it so that you keep getting put in the "deal with it 
later" bucket.
If you put related changes in a patch series, it will be easier to keep 
track of.  (See http://wiki.xenproject.org/wiki/Submitting_Xen_Patches 
for a description of how to do this with git send-email .)
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel