Re: [Xen-devel] [PATCH] X86: Fix vcpu xsave bug

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.11.13 at 19:52, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

Please don't to-post.

> No, what I meant is, nonlazy xstates should be xsaved each time 
> vcpu_save_fpu.
> Operation to nonlazy xstates will not trigger #NM exception, so whenever 
> vcpu scheduled in it should get restored and whenever vcpu scheduled out it 
> should get saved.

So you're saying that AMD's LWP would be broken in that respect
currently too. Hence in any event this needs to be coordinated
with AMD, and the description needs improving.

> As for the comments I just want to unify it with other 'clts' comments.

But you're making an admittedly non-optimal comment completely
wrong - there's no recursion involved in triggering #NM there.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel