Re: [Xen-devel] [PATCH 0 of 4 V5] Remus/Libxl: Network buffering support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2013-11-18 at 12:03 -0800, Shriram Rajagopalan wrote:
> This patch series adds support for network buffering in the Remus
> codebase in libxl.  NB: This series does not contain the
> bug fix related to usleep calls in libxl__domain_suspend.
> I will send it out later as a separate series.
> 
> Changes in V5:
> 
> Merge hotplug script patch (2/5) and hotplug script setup/teardown
> patch (3/5) into a single patch.

This has dropped to 4 patches vs 7 in v4. One of the delta is this
merging, what happened to the other two? Especially given that Ian J
asked for #7 to be split last time around.

From an initial glance this looks like code this time around is that
right? I know some stuff is to come later but IIRC that wasn't in the
previous series either.

From a release point of view (George CCd) it looks like it only touches
Remus code other than a few little changes in the generic save/restore
code which are guarded by (in effect) if (remus). Is that correct?

If the only risk is to Remus users and the plus side is a far more
useful Remus then I'd say we should make a freeze exception, subject to
the code being reviewed of course.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel