[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] pvh: clearly specify used parameters in vcpu_guest_context

>>> On 19.11.13 at 17:42, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
> On 19/11/13 16:34, Jan Beulich wrote:
>>>>> On 19.11.13 at 16:04, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
>>> On 19/11/13 14:32, Jan Beulich wrote:
>>>> Also, by now honoring CR0 and CR4 settings, you again move
>>>> towards the hybrid model (some fields honored, some refused)
>>>> that was (I think by you) previously described as unacceptable.
>>> From a strict POV we should just set cr3, flags and user_regs, but then
>>> Tim mentioned also honouring cr0/cr4,
>> I understood his response to mean all fields, or none of them.
> Trying to make all those fields functional on PVH (or HVM) is quite
> useless IMHO, it's going to add more code that I doubt anyone is going
> to use when you can instead use the bare metal functions to set all
> those things (and from an OS point of view it's also more comfortable
> because you need less Xen specific stuff).

That last part I certainly agree to, but that would apply to CR0
and CR4 just as much.

> When you refer to not using any fields, does this mean to enable LAPIC
> for PVH and use the bare metal CPU bringup method?

Clearly not.

> And I guess introducing a new hypercall (that also uses a different
> vcpu_guest_context struct) to bringup vcpus inside of HVM domains is
> completely out of the picture?

It would seem awkward.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.