Re: [Xen-devel] [PATCH v5] xenbus_client: extend interface to suppurt multi-page ring

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 10/11/13 17:21, Wei Liu wrote:
> Originally Xen PV drivers only use single-page ring to pass along
> information. This might limit the throughput between frontend and
> backend.
> 
> The patch extends Xenbus driver to support multi-page ring, which in
> general should improve throughput if ring is the bottleneck. Changes to
> various frontend / backend to adapt to the new interface are also
> included.
> 
> Affected Xen drivers:
> * blkfront/back
> * netfront/back
> * pcifront/back
> * tpmfront
> 
> The interface is documented, as before, in xenbus_client.c.

It looks ok to me so I guess:

Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>

But, I think this should wait until either:

a) There's an in kernel user that uses multipage rings

or

b) You demonstrate multi page rings have been tested with some sort of
unit test.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel