Re: [Xen-devel] [PATCH v3 5/7] libxl: vNUMA configuration parser

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

Just one thing (for now)...

On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote:
> Signed-off-by: Elena Ufimtseva <ufimtseva@xxxxxxxxx>

> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 8690ec7..d7aa0b3 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
>
This is the only file you modify in the patch, so the patch itself is
about _xl_, rather than _libxl_, isn't it?

Please, make the subject consistent with that.

It's a big patch (and it should be even bigger, as you'll see from my
comments on patch 7/7) so, perhaps, consider splitting it up, e.g., by
having one patch for each new config option introduced (if feasible and
not too hard).

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel